Add generic devices to WorkloadStatus - #32
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bleggett
left a comment
bleggett
left a comment
There was a problem hiding this comment.
WORKLOAD_MOUNT_SCOPE_TYPE_UNKNOWN = 0;
WORKLOAD_MOUNT_SCOPE_TYPE_ZONE = WORKLOAD_MOUNT_SCOPE_TYPE_WORKLOAD = 2;
Ok, originally I thought that this was meant to be
xen==WORKLOAD_MOUNT_SCOPE_TYPE_ZONEkvm==WORKLOAD_MOUNT_SCOPE_TYPE_WORKLOAD
and wasn't sure why we couldn't just derive this at runtime without exposing this policy field in the control API.
but @clupuishere mentioned that in fact kvm can support either policy and there might be perf/runtime reasons why you might want to use both policies interchangeably for the same virt backend at the same time.
That was the bit of info I didn't have/didn't register with me, so lgtm.
We are introducing WorkloadDeviceStatus and WorkloadDeviceInfo to define handlers for managing devices in an uniform and generic way. We have been rolling so far with standalone message types for block (WorkloadBlockDeviceInfo message type) and PCI (WorkloadPciDeviceInfo message type) devices and adding support for a new device type (WorkloadFsDeviceInfo message type) raises an immediate need to have a more scalable and generic way of handling devices. Signed-off-by: Costin Lupu <costin@edera.dev>
|
Confirming @bleggett's comment. However, for the latest revision of this PR I decided to drop the |
4 participants
The current changes are needed to add support for mounts per workload. Since we are introducing a new type of devices, filesystem devices, we need a more generic way of handling devices. With filesystem devices we can share host directories either as unified mounts per zone or as one mount per workload.