fix(spire): drop SPIRE stuff from the control API, now unused - #51
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bleggett
marked this pull request as ready for review
August 14, 2026 23:08
antoineco
approved these changes
Aug 14, 2026
bleggett
enabled auto-merge (squash)
August 17, 2026 17:55
bleggett
disabled auto-merge
August 17, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're doing this a different way, such that SPIRE ops no longer need to be part of the public control API.
This will fail lints because I am outright deleting RPCs and messages and that is a Protobuf breaking chaneg, but as I know for a fact we are the only consumer, those can be ignored.