Repository navigation
fix(pi-leader-key): move leader palette shortcut to Ctrl+Q - #3
Merged
Merged
Conversation
Pi already uses ctrl+x for app.message.copy, so the extension shortcut was skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Rebound pi-leader-key off conflicting ctrl+x to Ctrl+Q. Keep /lk. Update README, extensions/pi-leader-key/AGENTS.md, and any tests/docs that still say Ctrl+X. Do not add a settings/config layer unless the existing code already has one. Do not touch pi-tool-pills. Confirm the new chord against Pi's own keybinding docs/source so current installed Pi does not already bind it. Atlas-Key signed commit and PR; attach exactly one risk label (risk:low|medium|high|critical).
What Changed
Ctrl+XtoCtrl+Qwhile preserving the/lkcommand.Ctrl+Xbinding.Ctrl+Qis registered and both supported triggers open the overlay.Risk Assessment
✅ Low: The change is a bounded shortcut rebinding with aligned documentation;
/lkremains intact, no configuration layer or pi-tool-pills changes were introduced, the Atlas-Key signature is valid, and installed Pi 0.84.2 reserves Ctrl+X but has no Ctrl+Q binding.Testing
After repairing the initially missing local dependencies with an offline, script-disabled install, the focused registration test passed; installed Pi 0.84.2 confirmed Ctrl+X is occupied and Ctrl+Q is free, and live TUI captures visibly demonstrated both Ctrl+Q and
/lkopening the palette before all transient test state was cleaned up./var/folders/88/3h9cyc4979d2l6p7xkn79yqr0000gn/T/no-mistakes-evidence/01M0E15EBVSWFFV82GT2V5QR47/ctrl-q-palette.png)/var/folders/88/3h9cyc4979d2l6p7xkn79yqr0000gn/T/no-mistakes-evidence/01M0E15EBVSWFFV82GT2V5QR47/slash-lk-palette.png)Evidence: Installed Pi keybinding audit
Installed Pi: 0.84.2 Ctrl+X: app.message.copy and app.models.clearAll Ctrl+Q: no assignment in shipped keybinding docsPipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff --name-status 0ebf037ca4df1c6385e641989a4fd71d8702369d 90c353d4d42752ddf4c3fed451593d2cb20e4a82git show --show-signature --format=fuller --no-patch 90c353d4d42752ddf4c3fed451593d2cb20e4a82Repository-widergfor stale pi-leader-key Ctrl+X references and installed Pi keybindingspnpm exec vitest --run --root . extensions/pi-leader-key/tests/overlay.unit.test.ts(initially exposed missing dependencies)pnpm install --frozen-lockfile --offline --ignore-scriptspnpm exec vitest --run --root . extensions/pi-leader-key/tests/overlay.unit.test.ts(retry passed)BoundedPI_OFFLINE=1 pi --no-extensions … -e ./extensions/pi-leader-key/src/index.tstmux sessiontmux send-keys … C-qand reviewer-visible pane capturetmux send-keys … -l '/lk'plusEnterand reviewer-visible pane captureImageMagick rendering and visual inspection of both live TUI capturesRemoved the bounded tmux session and transientnode_modulesdependency tree✅ **Document** - passed
✅ No issues found.
⏭️ **Lint** - skipped
extensions/pi-leader-key/tests/overlay.unit.test.ts:45- Scoped static analysis fails with TS2493: the mock is inferred as zero-argument, so accessing custom.mock.calls[0]?.[1] is invalid; this pass forbids modifying tests.✅ **Push** - passed
✅ No issues found.