Skip to content

Use Node.js 8 as a minimum engine version#1

Open
dyatko wants to merge 1 commit into
eduardbme:masterfrom
dyatko:patch-1
Open

Use Node.js 8 as a minimum engine version#1
dyatko wants to merge 1 commit into
eduardbme:masterfrom
dyatko:patch-1

Conversation

@dyatko

@dyatko dyatko commented Jul 17, 2018

Copy link
Copy Markdown

No description provided.

@alexilyaev

Copy link
Copy Markdown

@eduardbcom If this package would work with Node v8, this PR would be very much appreciated.

@rochdev

rochdev commented Aug 10, 2018

Copy link
Copy Markdown

@dyatko Why not go even lower? Since this is a fork of the original memwatch, it should support as low as 0.8.0.

@dyatko

dyatko commented Aug 10, 2018

Copy link
Copy Markdown
Author

@rochdev I have no clue.
I just needed to get it to work with Node.js 8, which is the current LTS.

@rochdev

rochdev commented Aug 10, 2018

Copy link
Copy Markdown

@dyatko Fair enough :) BTW I found this one that is already updated: https://www.npmjs.com/package/@airbnb/node-memwatch

@nmccready

Copy link
Copy Markdown

What is going on with this ? yarn --ignore-engines seems to prove that this works fine with 8.X .

@nmccready

Copy link
Copy Markdown

Is there something in particular that possibly makes it not work with 8.X? Also, one big downside of @airbnb's fork is the loss of leak (leak event) detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants