-
-
Notifications
You must be signed in to change notification settings - Fork 38
Educates refactoring #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorgemoralespou
wants to merge
28
commits into
educates:develop
Choose a base branch
from
jorgemoralespou:educates-refactoring
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Educates refactoring #871
jorgemoralespou
wants to merge
28
commits into
educates:develop
from
jorgemoralespou:educates-refactoring
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvices in compose
Closed
| "jquery": "^3.7.1", | ||
| "js-yaml": "^4.1.1", | ||
| "lodash": "^4.17.23", | ||
| "lodash": "^4.17.21", |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You managed to revert version to an older one, overriding recent updates due to CVE and npm audit. Possibly reverted package-lock.json files as well in other places, so npm audit will need to be done again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to avoid code duplication.
educates local config editthat does validation and prevents saving on erroreducates local mirror listcommand--kubernetes-versionflag toeducates create-clusterand defaults to 1.34 and defines the kind images by sha to use.educates docker workshop deploy. It creates port bindings for additional services containers.This has been rebased on latest develop, and updated to supersede #855. More commits will come later but guaranteeing that we keep this aligned with develop.
With these changes, you can now survive Docker Desktop restarts and also install Educates on a machine without internet connection (as long as prepopulated mirrors and docker images are already present on the system). Supersedes #851