ci: fold actionlint into mise lint, dry-run as task (DOT-47)#74
Merged
Conversation
actionlint validates workflow semantics that treefmt and shellcheck do not (expression syntax, runner labels, job needs, and shellcheck over run: scripts). Add it to the mise toolchain and call it from the lint task so the check runs locally too, then drop the separate actions_lint CI job. CI goes from four jobs to three. Move the chezmoi dry-run command into an apply-dry-run mise task so the workflow calls the task instead of carrying an inline mise exec script. Remove the reset-config task; re-running chezmoi init covers it and it saw little use. Keep reset for clearing run_onchange script state. Fixes DOT-47
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI and mise task hygiene. Fold GitHub Actions linting into
mise lint, move the chezmoi dry-run out of an inline pipeline script, and drop a rarely-used task.Changes
mise lint. Addedactionlint = "1.7.12"to the mise toolchain (same version as the old docker pin) and called it from the lint task. It validates workflow semantics treefmt/shellcheck cannot (expression syntax, runner labels,needs:, and shellcheck overrun:blocks) and reuses the shellcheck already installed. The separateactions_lintCI job is removed, so CI goes 4 jobs to 3 andmise lintnow catches workflow bugs locally.apply-dry-runmise task. Thechezmoi_dry_runjob now callsmise apply-dry-runinstead of an inlinemise exec -- chezmoi apply ...script.reset-configtask. Re-runningchezmoi initcovers it; it saw little use. Keptresetfor clearing run_onchange script state.Verification
mise lintruns actionlint (verified it passes on the current workflows and flags a deliberately broken${{ }}expression).apply-dry-runtask registered;reset-configgone,resetkept.Fixes DOT-47