chore: consolidate formatter ignores into treefmt (DOT-48)#75
Merged
Conversation
taplo.toml held only include/exclude globs and no formatting rules, and .prettierignore only listed paths. treefmt already dispatches both tools by glob, so move the excludes (*.tmpl and the vendored tests/test_helpers libraries) into the prettier and taplo formatter blocks and delete the two root files. treefmt now owns all file selection; mise format reports no change, so output is identical. Fixes DOT-48
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove two root config files by moving their file-selection into
treefmt.toml, which already dispatches these formatters.Changes
taplo.toml. It held only include/exclude globs and no formatting rules, so it duplicated selection treefmt already does. Its*.tmplandtests/test_helpersexcludes move into[formatter.taplo]..prettierignore. Its excludes move into[formatter.prettier].excludes.treefmt now owns all file selection; no per-tool ignore files at the repo root.
Tradeoff (accepted)
Verification
mise formatreports 0 files changed (identical output;*.tmpland vendored test_helpers still skipped).mise lintclean.Fixes DOT-48