Don't add ellipsis if the string to be truncated is exactly the max allowed length#6
Open
ismail-s wants to merge 3 commits intoeentzel:masterfrom
Open
Don't add ellipsis if the string to be truncated is exactly the max allowed length#6ismail-s wants to merge 3 commits intoeentzel:masterfrom
ismail-s wants to merge 3 commits intoeentzel:masterfrom
Conversation
If the input str is shorter than the target_len, then we needn't bother tokenizing it all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the added test in this PR for a better explanation.