feat(serve): Cmd/Ctrl+K command palette - #69
Merged
Merged
Conversation
Cmd/Ctrl+K only focused the small header field, and on a narrow window that field is hidden, so the shortcut silently switched to More › Search. It now opens a palette over the page: - empty: recent searches, the findings to look at first, views, actions - typing: fuzzy match over views, More sections, findings (plain title or rule id) and conversations, instantly; matching actions from the evidence via /api/search a moment later, with a visible pending line - keys: up/down/Tab, Enter, Cmd/Ctrl+Enter for the full search, Esc clears then closes; "/" opens it too; header field and a phone search button open the same palette - dialog + combobox + listbox semantics, focus never left in the hidden input, secrets masked in every result, reduced-motion respected Existing shortcuts (physical-key matching, j/k, drawer Esc) unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cmd/Ctrl+K only focused the small header field; there was no popup. On a narrow window that field is hidden, so the shortcut silently switched to More › Search.
What
A command palette over the page:
/api/search, events only) arrive a moment later, with a visible "Searching every recorded action…" line meanwhile./opens it too. The header field and a new phone search button open the same palette.aria-activedescendant; focus never left in the hidden input; secrets masked in every result; dark mode; reduced motion.Existing shortcuts are unchanged: physical-key matching, j/k in Activity, arrows in Findings, Esc closes the drawer.
Verified
go test ./...green, newTestCommandPalette, existingTestShortcutsMatchPhysicalKeysstill passes./opens; Cmd+↵ runs the full search; fuzzy "overvw" → Overview; header click opens; j still works; phone width shows the search button and it opens. No console errors. The first run caught a focus bug (keys typed into the closed palette), fixed and re-verified.Generated with Claude Code