fix(scope-audit): put the collector links where a reader with data sees them - #10
Merged
Merged
Conversation
…es them The links to both collectors lived only in the empty state, which by definition never renders on an instance that HAS data. So on the deployment this page was built for, 197 rows and 199 collected targets, the provenance note named the two collectors in prose and linked neither. Exactly the readers best placed to act on it could not. sourcesLineHtml now carries both links itself and is extracted and exported so the gap is asserted rather than assumed: four tests covering two links present, rel="noopener" on both, the declared-versus-observed distinction stated, and the newest-answer-wins rule visible to a reader who never sees the empty state. CoreDrive RX points at https://rx.on8ar.eu/ here. Upstream keeps the repo URL, since a hosted instance is this deployment's, not everyone's. The empty-state assertion accepts either form rather than pinning one fork's URL. 680 passed, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQS3XLoPD98yu9pxdRujqg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector links lived only in the empty state, which never renders on an instance that has data. On this deployment (197 rows, 199 collected targets) the provenance note named both collectors in prose and linked neither, so exactly the readers best placed to act on it could not.
sourcesLineHtmlnow carries both links and is extracted and exported so the gap is asserted rather than assumed: two links present,rel="noopener"on both, the declared-versus-observed distinction stated, and the newest-answer-wins rule visible to a reader who never sees the empty state.CoreDrive RX points at https://rx.on8ar.eu/ here; upstream keeps the repo URL, since a hosted instance is this deployment's rather than everyone's. The empty-state assertion accepts either form rather than pinning one fork's URL.
680 passed, 0 failed.