feat(scope-audit): explain where the declared data comes from - #8
Merged
Conversation
…urs is empty Nobody reading this page could tell how the declared list reaches the database or why theirs might hold nothing. The old empty state said it "fills in as devices drive and answer over RF", which is CoreDrive-specific jargon that says nothing to an operator running the observer firmware instead, and names no collector at all. Two changes: - A provenance line under the intro, always visible: the declared side is the repeater's own answer read back off the node, the observed side is forwarding CoreScope already sees in its own traffic. That distinction is the whole point of the page and it was never stated. - The empty state now carries the full explanation, because on a stock install it IS the page. It names both collectors with links (the ESP32 neighbour-report firmware and the CoreDrive RX app), states that neither ships with CoreScope so an empty table is the normal state rather than a fault, gives the precedence rule now that there are two sources, and says the thing that justifies the page existing: nothing else in CoreScope knows which regions a repeater is CONFIGURED for, only which ones its traffic was seen under. emptyStateHtml is extracted and exported rather than left inline so it can be asserted. Six tests: both collectors named, both linked, empty-is-normal stated, precedence stated, the configured-vs-observed distinction present, and the old drive-around wording gone. 670 to 676 passed, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PQS3XLoPD98yu9pxdRujqg
efiten
force-pushed
the
fix/scope-audit-neutral-unobserved
branch
from
September 6, 2026 12:08
3355c3a to
0d1961b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a provenance line under the intro and rewrites the empty state, which on a stock install is the whole page. Names both collectors (ESP32 neighbour-report firmware, CoreDrive RX) with links, says an empty table is normal rather than a fault, gives the newest-answer-wins rule, and states what nothing else in CoreScope can tell you: which regions a repeater is configured for, as opposed to which ones its traffic was seen under. Old wording said it "fills in as devices drive", which meant nothing to anyone not using CoreDrive.
emptyStateHtmlextracted and exported so it is testable; 670 to 676 passed.