Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf(test): transpile runtime .ts imports with oxc-node instead of tsx #5965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
perf(test): transpile runtime .ts imports with oxc-node instead of tsx #5965
Changes from all commits
28cf009280fa84d8c61289a32d71File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: eggjs/egg
Length of output: 16432
🏁 Script executed:
Repository: eggjs/egg
Length of output: 158
🏁 Script executed:
Repository: eggjs/egg
Length of output: 158
🏁 Script executed:
Repository: eggjs/egg
Length of output: 158
🏁 Script executed:
Repository: eggjs/egg
Length of output: 158
🏁 Script executed:
Repository: eggjs/egg
Length of output: 3643
Avoid re-injecting
tsx/esmintoNODE_OPTIONSwhen@oxc-node/core/registeris already set.vitest.config.tssetsNODE_OPTIONS: '--import=@oxc-node/core/register', buttegg/core/vitest/test/setup.tsstill appends--import=tsx/esmwhenevertsx/esmis missing—so the migration ends up enabling both hooks.Suggested follow-up adjustment
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix broken list paragraph indentation at Line 53.
'@eggjs/<x>/package.json'is split onto a new unindented line, which breaks the flow of the numbered item in rendered markdown.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the exact symbol name for clarity at Line 9.
mock.mockContext()reads like a namespace typo; elsewhere the API is referenced asmockContext().Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[style] ~9-~9: Unless you want to emphasize “not”, use “Cannot” which is more common.
Context: ...ning module resolution for later files (
Can not find plugin …). (2) `mock.mockContext(...(CAN_NOT_PREMIUM)
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.