-
Notifications
You must be signed in to change notification settings - Fork 2
feat(stjm): support .NET 8 and .NET 9 without JSON upgrades #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <Project> | ||
| <Import Project="../Directory.Build.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <!-- Retain older framework assets for hosts that cannot upgrade their runtime. | ||
| Their support end dates must not make newer SDKs reject these builds. | ||
| TODO: Re-enable this check when the retained targets are all supported. --> | ||
| <CheckEolTargetFramework>false</CheckEolTargetFramework> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...rf/Egil.SystemTextJson.Migration.PerfTests/Egil.SystemTextJson.Migration.PerfTests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...TextJson.Migration/src/Egil.SystemTextJson.Migration/Egil.SystemTextJson.Migration.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...emTextJson.Migration.Analyzers.Tests/Egil.SystemTextJson.Migration.Analyzers.Tests.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will likely break when .NET 8 and 9 go out of support (2026-11-10, same day as .NET 11 GA).
11.0.x(per the workflow comment),global.jsonrolls forward to that SDK.net8.0andnet9.0.-warnaserror, and Release builds setTreatWarningsAsErrorsin the rootDirectory.Build.props, so that warning becomes an error. SDK 9.0.100 did the same tonet6.0on its release day.Suggested fix: opt out of the check with the documented
CheckEolTargetFrameworkproperty. It states intent better than addingNETSDK1138toNoWarn.Directory.Build.props(or to a package-level one, if you'd rather keep it scoped to this package):verify-analyzer-package.ps1writes them to a temp dir, andverify-trimming-package.ps1stubs outDirectory.Build.props. So add the property inline to each generated<PropertyGroup>:Consumer.csproj,InvalidConsumer.csprojandSeverityConsumer.csprojinverify-analyzer-package.ps1, plus the trimming consumer inverify-trimming-package.ps1:-p:CheckEolTargetFramework=falseto eachdotnet restore/build/publishcall in the scripts.)Generated by Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
CheckEolTargetFramework=falsein package-levelDirectory.Build.props, which explicitly imports the root props so existing build settings remain intact. It is also inline in all three analyzer consumer projects and the trimming/AOT consumer project. Other packages retain their existing SDK support checks.The Release solution build passed on all four targets with zero warnings/errors. I simulated SDK end-of-support checks for .NET 8/9 across the package projects and all four generated consumer templates: the new settings passed, while controls with
CheckEolTargetFramework=truefailed withNETSDK1138.Updated in
87b1f31; the PR still contains one commit.