Skip to content

[CI] Restore green main after Clippy and generated-doc drift #407

Closed

Description

@szmyty

Outcome

Restore a truthful green main baseline before adding more Renderflow product surface.

Observed baseline

Checked on 2026-09-13 against main at 58aa2cad8ba9e2374d0e7a1bf5277052ae40838c.

Two current required checks are failing:

  1. Build and test / Clippy
    • crates/renderflow-core/src/commands/build.rs
    • run_selection currently has eight parameters and fails under -D warnings with clippy::too_many_arguments.
  2. Generated documentation drift
    • docs/user-guide/tool-registry.md does not match the canonical generator output.
    • The reported delta includes HandBrake and Lulu rules/capabilities.

The web checks, installer, Snap, and AUR jobs observed in the same baseline are succeeding. This is a focused baseline-repair issue, not a reopening of the older packaging incident resolved by #351.

Scope

  • Refactor the wide run_selection call boundary into a typed request/options object, or document a narrower alternative that preserves behavior.
  • Do not silence the lint globally or weaken -D warnings.
  • Regenerate docs/user-guide/tool-registry.md through the canonical generator and commit the exact generated result.
  • Confirm the underlying registry sources for HandBrake and Lulu are intentional and covered by the documentation contract.
  • Add or strengthen a regression check if the current checks can drift without a locally reproducible failure.
  • Run the complete required validation suite and record the evidence.

Acceptance criteria

  • cargo fmt --check passes.
  • Clippy passes with warnings denied for the same targets/features used in CI.
  • The relevant unit/integration tests pass.
  • The generated-document check is clean from a fresh checkout.
  • No lint, documentation, or workflow gate is bypassed to obtain green status.
  • Required GitHub Actions checks are green on the resulting main commit.
  • Completion evidence is linked from this issue and reconciled with the universal artifact roadmap in Roadmap: universal artifact forest, maximal Renderflow profile, and Flow orchestration readiness #367.

Related work

Activity

  1. szmyty commented on Sep 13, 2026

    @szmyty
    ContributorAuthor

    Implementation evidence (PR pending)

    • Focused PR: fix(pipeline): restore validation baseline #408
    • Pinned base: 58aa2cad8ba9e2374d0e7a1bf5277052ae40838c
    • Current head: 15478e75862be680dc0e882aff3cafbe5aa56300
    • The remote tree matches the fully validated local tree: 3a967ce4babaadc4df1c94e6dc1a9e9a5b7d3d21
    • No dependencies, workflow gates, warning policy, or capability contracts changed.

    Local validation passed for Rust 1.94 formatting, exact workspace Clippy with warnings denied, verbose workspace build, the complete workspace unit/integration/doc-test suite, locked fast conformance, all canonical docs/schema generators with a clean generated diff, strict MkDocs and Mike preview, the full web matrix, release/example checks, and checksum-verified installer smoke testing.

    The canonical registry history confirms HandBrake (1db6150a) and Lulu (bb34bd27) are intentional existing providers; this PR only brings their generated reference rows back into sync.

    The first hosted Commit Lint run found a commit-body line-length violation. The commit was amended without changing the tree, and latest-head checks are running:

    The PR is intentionally unmerged. Keep the main-branch acceptance item open until #408 is reviewed/merged and resulting-main evidence is observed; hosted execution may also need an account billing/quota follow-up. Reconciliation with #367: no new artifact capability or dependency was introduced, so its sequencing is unchanged.

  2. szmyty commented on Sep 13, 2026

    @szmyty
    ContributorAuthor

    Hosted-check follow-up for head 15478e75862be680dc0e882aff3cafbe5aa56300: Commit Lint and Artifact conformance are now green. CI and docs remain in progress; the PR remains open and unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions