docs: add third-party notices for climatedatastore-derived code - #60
Merged
Conversation
Several task and utility functions plus the release workflow were adapted from mathworks/climatedatastore, whose license requires retaining the copyright notice, conditions, and disclaimer with redistributed source, and keeps derivatives under its own terms rather than MIT. - Add THIRD_PARTY_NOTICES.md listing the adapted files and reproducing the climatedatastore license verbatim - Scope the MIT grant in LICENSE to exclude the adapted portions - Normalize per-file attribution headers to name the specific source file and point at THIRD_PARTY_NOTICES.md, adding headers to codecheckToolbox.m and testToolbox.m which lacked them Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Test Results23 tests 23 ✅ 19s ⏱️ Results for commit 1f6d1eb. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 42.02% 43.16% +1.13%
==========================================
Files 59 61 +2
Lines 1468 1522 +54
==========================================
+ Hits 617 657 +40
- Misses 851 865 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Uses the RootFilesToPackage mechanism from #61 so the license and third-party notices ship inside packaged toolbox releases, covering the binary-redistribution condition of the climatedatastore license. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
'Repository root' is wrong for users who installed the .mltbx, where THIRD_PARTY_NOTICES.md sits at the installed toolbox root instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several MatBox functions and the release workflow were adapted from mathworks/climatedatastore. Its license (BSD-2-style with a MathWorks-products-only clause) requires that redistributed source retain the copyright notice, conditions, and disclaimer, and that derivatives remain under its terms rather than being relicensed. This PR brings MatBox into compliance and makes the attribution consistent:
Adapted from:/CREDIT:lines to name the specific source file and reference THIRD_PARTY_NOTICES.md; added headers tocodecheckToolbox.mandtestToolbox.m, which are also derived (shared structure, comments, and version-check logic) but previously carried no attributionLICENSEandTHIRD_PARTY_NOTICES.mdinRootFilesToPackage(the mechanism from feat: include project root files in packaged toolbox #61) so both files ship inside packaged.mltbxreleases, covering the license's binary-redistribution conditionDerivation was verified by direct comparison with the climatedatastore sources.
🤖 Generated with Claude Code