fix: forward the bump input to the release workflow - #65
Merged
Conversation
The workflow declared the bump dispatch input but never passed it to
prepare-release-workflow, so a bump-only dispatch sent an empty version
downstream and version validation failed on ref_name ('main').
Requires matbox-actions v1.6 (the release that ships the bump input on
prepare-release-workflow).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dispatching Prepare toolbox release with a bump type (and no explicit version) failed:
The workflow declared the
bumpdispatch input (added in #64) but never forwarded it — thewith:block only passedversionandref_name. A bump-only dispatch therefore sent an emptyversiontoprepare-release-workflow, whose version validation fell back to interpretingref_name(main) as a release tag.One line: forward
bump: ${{ inputs.bump }}, matching the matbox-actions workflow template.Dependency
Merging this requires matbox-actions v1.6 (in flight):
@v1currently resolves to v1.5, whoseprepare-release-workflow.ymldoes not declare abumpinput, and passing an undeclared input to a reusable workflow is a hard error. Once v1.6 is published andv1moves, this works as-is. Until then, the explicitversionoverride input still works for releases.🤖 Generated with Claude Code