Skip to content

fix(sim): address PR #15 review gaps - #18

Merged
eisber merged 2 commits into
mainfrom
takeover/pr-15-review-fixes
Sep 8, 2026
Merged

eisber merged 2 commits into
mainfrom
takeover/pr-15-review-fixes

Conversation

@eisber

@eisber eisber commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Follow-up to #15 and #16.

  • select InputRef sources from graph connectivity and preserve wired analog zero values
  • mirror InputRef consistently in interpreted and compiled engines
  • make PushButton-family InputDisable suppress Reset, On, and Trigger
  • align PushButton2 On behavior across both engines
  • add focused parser, Reset, Disable, and parity regression coverage

eisber and others added 2 commits September 8, 2026 18:20
Select InputRef sources from graph connectivity and mirror values in both simulator engines. Make PushButton disable all peripheral inputs and add focused Reset, Disable, On, and JIT parity coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use fixed-size slice chunks when decoding serialized floating-point state.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@eisber
eisber merged commit 6830ac1 into main Sep 8, 2026
11 of 12 checks passed
@eisber
eisber deleted the takeover/pr-15-review-fixes branch September 8, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant