Add environment variable abstraction and harden build service tests#2585
Open
Add environment variable abstraction and harden build service tests#2585
Conversation
- Add IEnvironmentVariables interface and SystemEnvironmentVariables implementation for testable environment variable access - Add SymlinkValidator to prevent path traversal attacks via symlinked control files (docset.yml, toc.yml, redirects.yml) - Update IsolatedBuildService and AssemblerBuildService to use IEnvironmentVariables - Add validation that --assume-build flag throws error on CI to prevent stale builds - Create comprehensive unit tests with truth tables documenting: - CI behavior (always forces full rebuild, always clears output) - Force parameter behavior and CI override logic - assumeBuild validation on CI
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
The --assume-build flag is blocked on CI by the new environment variable validation, but the integration test fixture always passed it. On CI there is no cached build output so the flag was effectively a no-op anyway. Conditionally exclude it when GITHUB_ACTIONS is set so the integration tests do a fresh build on CI while preserving fast local reruns.
New Codex command files from main were missing the IEnvironmentVariables parameter added to IsolatedBuildService's constructor in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IEnvironmentVariables interface and SystemEnvironmentVariables implementation
for testable environment variable access
Update IsolatedBuildService and AssemblerBuildService to use IEnvironmentVariables
Add validation that --assume-build flag throws error on CI to prevent stale builds
Create comprehensive unit tests with truth tables documenting: