Conversation
reakaleek
reviewed
Feb 23, 2026
reakaleek
requested changes
Feb 23, 2026
| ] | ||
| """; | ||
|
|
||
| var deserialized = JsonSerializer.Deserialize<ApplicableTo>(json, _options); |
Member
There was a problem hiding this comment.
I don't think we need to test the JSON deserializer
Contributor
Author
There was a problem hiding this comment.
Yeah, changed it to the pattern elsewhere in the tests now.
Member
There was a problem hiding this comment.
Ah nevermind. I just realized the alias logic is within the serializer?
tests/Elastic.Markdown.Tests/AppliesTo/ApplicableToJsonConverterRoundTripTests.cs
Outdated
Show resolved
Hide resolved
reakaleek
approved these changes
Feb 23, 2026
Member
reakaleek
left a comment
reakaleek
left a comment
There was a problem hiding this comment.
Approving. But I think we should get feedback from @shainaraskas.
shainaraskas
approved these changes
Feb 23, 2026
Contributor
Author
|
As the scenario where using both in the same applicability statement would incur information loss for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563
Summary
This PR fixes gaps in the support for treating the
echdeployment subtype as an alias foress, ensuring consistent handling across JSON, YAML, and Markdown sources.Test coverage
echis deserialized asess, serializes back asess, and that when bothessandechare present, the correct precedence is applied.