Skip to content

Decode all opamp agent capabilites#6830

Merged
michel-laterman merged 3 commits intoelastic:mainfrom
michel-laterman:fix/opamp-decode-all-capabilites
Apr 14, 2026
Merged

Decode all opamp agent capabilites#6830
michel-laterman merged 3 commits intoelastic:mainfrom
michel-laterman:fix/opamp-decode-all-capabilites

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

What is the problem this PR solves?

Decode all capabilites an opamp agent can send.

How does this PR solve the problem?

Use the upstream protobufs.AgentCapabilities_name as the source of truth to map a capability to a human-readable name.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Decode all capabilites an opamp agent can send.
@michel-laterman michel-laterman added the bug Something isn't working label Apr 13, 2026
@michel-laterman michel-laterman requested a review from a team as a code owner April 13, 2026 19:06
@michel-laterman michel-laterman added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Apr 13, 2026
ycombinator
ycombinator previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing. Would be nice to have a unit test for decodeCapabilities but it's not super critical as the function is pretty straightforward.

@michel-laterman michel-laterman merged commit ed825c2 into elastic:main Apr 14, 2026
11 checks passed
@michel-laterman michel-laterman deleted the fix/opamp-decode-all-capabilites branch April 14, 2026 16:49
mergify bot pushed a commit that referenced this pull request Apr 14, 2026
* Decode all opamp agent capabilites

Decode all capabilites an opamp agent can send.

* Silence linter

* add unit tests

(cherry picked from commit ed825c2)
michel-laterman added a commit that referenced this pull request Apr 14, 2026
* Decode all opamp agent capabilites

Decode all capabilites an opamp agent can send.

* Silence linter

* add unit tests

(cherry picked from commit ed825c2)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.4 bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OpAMP] fleet-server should decode all agent capabilities

2 participants