Skip to content
This repository was archived by the owner on Apr 13, 2026. It is now read-only.

replaced Logstash initscript with one tailored for Logstash-forwarder#39

Open
poolski wants to merge 1 commit into
elastic:masterfrom
poolski:master
Open

replaced Logstash initscript with one tailored for Logstash-forwarder#39
poolski wants to merge 1 commit into
elastic:masterfrom
poolski:master

Conversation

@poolski
Copy link
Copy Markdown

@poolski poolski commented May 5, 2015

This is a self-contained initscript for LSF. It assumes installation in /opt/logstash-forwarder/.

@igalic
Copy link
Copy Markdown

igalic commented May 6, 2015

shouldn't we just use the one that logstashforwarder creates with pleaserun during its package creation?

@igalic
Copy link
Copy Markdown

igalic commented May 6, 2015

i just realized that option indirectly exists, and is init_template == undef

@poolski
Copy link
Copy Markdown
Author

poolski commented May 6, 2015

I do agree that using the initscript generated with pleaserun is more flexible, but this can be a good alternative for when you are just using a binary deployed with Puppet instead of a package.

@electrical
Copy link
Copy Markdown

Hi,

The init script here is not used by default. we use the packaged init script supplied by LSF it self.
This init script was put in place before LSF had a decent init script in place :-)

@electrical
Copy link
Copy Markdown

Can one of the admins verify this patch?

@oloc
Copy link
Copy Markdown

oloc commented Jul 10, 2015

In my opinion the best thing to do is to write a new template of the init script. Why ? Because we need to take care of the definition of some puppet arguments and transfer (sorry for my English) them to the init script.

Something like that :

name=logstash-forwarder
#name=<%= scope.lookupvar('logstashforwarder::lsf_name') %> # need PR #54
program=<%= @installpath %>/bin/$name
args=-config\ <%= @configdir %>/$name.conf

Therefore I pull request #56

@ghost
Copy link
Copy Markdown

ghost commented Jul 20, 2015

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@ghost
Copy link
Copy Markdown

ghost commented Jan 13, 2016

Can one of the admins verify this patch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants