Conversation
… lines in span for line numbers
Fix useToolApprovals subscriber never running; 6 test files added
Task 5.1 — writes 55 Vitest browser tests across: - tool-result-bubble, artifact-card, branch-nav, suggested-prompts - pinned-bar, subagent-card, tool-approval-card, heading - thinking-view, code-block (super-codeblock API) 8 of 10 components reach ≥83% line coverage. code-block remains at 31% due to large component size.
queue-edit-form, queue-header, queue-item, queue-list, queue-pause-indicator, queue-selection-toolbar: 27 tests covering render by mode, selection toggle, edit submission, pause indicator. Track components layer in docs/reports/coverage.md.
- CI workflows: pnpm 12, latest actions, docs cache path fix - All Node deps bumped to latest (biome 2.5.x, vitest 5, vite 8, TS 7) - vitest 5: restore substring locator matching via browser.locators.exact - Fix 72 biome errors (incl. real bugs in code-block, tdZ reorder) - cargo update: clear all RUSTSEC vulnerabilities (audit: 0 found) - cargo fmt + clippy -D warnings clean (dead-code, collapsible-if, etc.) - 572/572 vitest tests and cargo nextest pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
feat/super-codeblockbranch had never run CI and, when set up, failed every job. This PR updates all dependencies to latest and resolves every resulting error so the pipeline is green end-to-end.What changed
CI workflows (
.github/workflows/*)ci.yml/docs.yml/marketing-assets.yml: pin pnpm 12, latest actions (checkout@v7,setup-node@v7,pnpm/action-setup@v6), fixeddocs.ymlcache path to the rootpnpm-lock.yaml.Frontend
--frozen-lockfileok).browser.locators.exact: false(vitest 5 changed the default totrue, which broke 10 browser tests).biome.jsonmigrated to schema 2.5.13; 72 lint errors fixed across ~40 files, including two real bugs incode-block.tsx(missingclearMatchesprop on a child component + a temporal-dead-zone crash) and a CSS specificity bug inApp.css.pnpm lint, ✅pnpm test(572/572).Rust (
src-tauri)cargo updatecleared all RUSTSEC vulnerabilities —cargo auditnow reports 0 found (was 12).cargo fmtnormalized formatting across 3 files.cargo clippy -- -D warningsnow passes: fixed dead-code debt (WIP scaffolding), collapsibleifchains, deprecatedollama_rs::Ollama::new→ builder API, implied trait bounds, redundant match guard, and unread fields.cargo fmt --check, ✅cargo clippy -D warnings, ✅cargo nextest run.Typecheck note
pnpm check(tsc) iscontinue-on-error: truein this repo. It still reports ~88 pre-existing errors — verified zero new regressions from this PR (same count with these changes stashed).Verification
pnpm lintpnpm test(572 pass)pnpm check(no new errors)cargo fmt --checkcargo clippy -- -D warningscargo nextest runcargo audit(0 vulnerabilities)