Repository navigation
Add Moodle 5.3 support, declare 4.0 - 5.3 support - #165
Merged
Merged
Conversation
Moodle 5.3 deprecates the global external_* class names, which now emit debugging when used. The external functions use the core_external classes instead, and a shared journal_external_api_base file aliases the global classes into core_external on Moodle 4.0 and 4.1, where the namespace does not exist yet. Remove the FEATURE_GROUPMEMBERSONLY case, deprecated in 5.3 and unused by core since 2.8. Add MOODLE_503_STABLE to the CI matrix with PostgreSQL 17 and MariaDB 11.4, which 5.3 requires, and use mariadb-admin for the MariaDB health check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Moodle 5.3 to the supported range without dropping 4.0 - 5.2.
Changes
external_*class names, and using them now emits debugging (which fails PHPUnit and Behat).get_entry,set_text,save_feedbackandview_journalnow use thecore_externalclasses.classes/external/journal_external_api_base.php(new): replaces the compatibility block that was duplicated in each of the four classes. On Moodle 4.0 and 4.1, wherecore_externaldoes not exist, it aliases the global classes into that namespace.lib.php: removed theFEATURE_GROUPMEMBERSONLYcase, deprecated in 5.3 and unused by core since 2.8.version.php:supportedis now[400, 503], release 5.3.0 (2026101200).requiresis still Moodle 4.0.MOODLE_503_STABLEjobs (PHP 8.3 and 8.4, pgsql and mariadb). Those jobs use PostgreSQL 17 and MariaDB 11.4, which 5.3 requires; other branches stay on 16 and 10.11. The MariaDB health check now usesmariadb-admin pingfor all jobs, becausemysqladminis not in the MariaDB 11 images.Testing
PHPUnit
mod_journal_testsuiterun locally, 26 tests / 57 assertions passing on both ends of the range:Not run locally: Behat, the versions in between, PostgreSQL/MariaDB, and the code checker. CI on this PR covers those.