Skip to content

test(sync-service): make StackSupervisor telemetry test synchronous #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erik-the-implementer wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

test(sync-service): make StackSupervisor telemetry test synchronous #4554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a30860f
test(sync-service): make StackSupervisor telemetry test synchronous
alco Jun 10, 2026
123a5f8
chore: add changeset for test-only sync-service change
alco Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-telemetry-test-isolation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@core/sync-service": patch
---

Test-only: make the StackSupervisor telemetry test synchronous to avoid serve_shape counter contamination from concurrently running tests. No runtime changes.
6 changes: 5 additions & 1 deletion packages/sync-service/test/electric/stack_supervisor/telemetry_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
if Electric.telemetry_enabled?() and Code.ensure_loaded?(ElectricTelemetry.Reporters.Prometheus) do
defmodule Electric.StackSupervisor.TelemetryTest do
use ExUnit.Case, async: true
# Not async: the Prometheus reporter attaches a global :telemetry handler for
# [:electric, :plug, :serve_shape], so concurrent async tests that emit that
# event (via the real serve_shape plug) leak into this reporter's per-status
# counters and make the exact-count assertions below non-deterministic.
use ExUnit.Case, async: false

alias Electric.StackSupervisor.Telemetry

Expand Down
Loading