feat(agents): embedder docker-sandbox options + modelCatalog on AgentHandlerResult#4569
Open
balegas wants to merge 2 commits into
Open
feat(agents): embedder docker-sandbox options + modelCatalog on AgentHandlerResult#4569balegas wants to merge 2 commits into
balegas wants to merge 2 commits into
Conversation
…HandlerResult Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4569 +/- ##
===========================================
+ Coverage 56.67% 70.98% +14.31%
===========================================
Files 327 83 -244
Lines 37935 9879 -28056
Branches 10938 3139 -7799
===========================================
- Hits 21498 7013 -14485
+ Misses 16401 2848 -13553
+ Partials 36 18 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…set bullets Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BuiltinAgentHandlerOptions.dockerSandbox?: { image, allowFloatingTag, env, extraMounts }— threads into the built-indockersandbox profile'sdockerSandbox()call (which already supports all of these). Custom mounts append after the working-directory mount.AgentHandlerResult.modelCatalog— exposes the catalogcreateBuiltinAgentHandleralready builds.resolveBuiltinModelConfig,resolveDockerSandboxOpts, and typesBuiltinModelCatalog,BuiltinAgentModelConfig,BuiltinDockerSandboxOptions,BuiltinDockerSandboxMount.Why
OpenFactory registers a custom Discord-facing agent entity alongside horton/worker. It needs (a) a sandbox image with git + gh + a GitHub-App token helper baked in, plus the GH_APP env/key mount inside the container, and (b) the same model-arg resolution the built-in agents use, without re-implementing the catalog.
Tests
packages/agents/test/docker-sandbox-options.test.tscovers the option merge (cwd-mount only, full passthrough, mount append, empty).🤖 Generated with Claude Code
Notes for reviewers
BuiltinDockerSandboxMountintentionally duplicates the runtime's mount item shape instead of importingDockerSandboxOpts— that type only exists on the@electric-ax/agents-runtime/sandbox/dockersubpath, which this package deliberately keeps out of its top-level import graph (docker code is reached via dynamic import only).env/extraMountsextend the existing embedder/operator trust boundary: same trust level as the embedder process itself, andextraMountsstays behind the runtime's docker-socket guard.