Rename agent event sources to webhook sources#4574
Open
KyleAMathews wants to merge 3 commits into
Open
Conversation
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4574 +/- ##
==========================================
- Coverage 57.31% 56.72% -0.60%
==========================================
Files 347 327 -20
Lines 39124 37951 -1173
Branches 11189 10944 -245
==========================================
- Hits 22425 21527 -898
+ Misses 16661 16388 -273
+ Partials 38 36 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Electric Agents Mobile BuildLocal mobile checks ran for commit The EAS Android preview build was skipped because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the agent-facing “event source” API to “webhook source” across runtime, server routes, tools, types, tests, and Horton prompts. This is a breaking terminology/API cleanup: agents now discover, subscribe to, wake from, and manage webhook sources via
*_webhook_source*names and/webhook-source-subscriptionsroutes.Root Cause
“Event source” was too generic for the feature being exposed: these subscriptions are specifically for external webhook ingress streams. Keeping the generic name made APIs, manifests, tool names, and downstream integration points harder to reason about.
Approach
EventSource*toWebhookSource*.list_event_sources→list_webhook_sourcessubscribe_event_source→subscribe_webhook_sourcelist_event_source_subscriptions→list_webhook_source_subscriptionsunsubscribe_event_source→unsubscribe_webhook_sourceevent-source:<id>→webhook-source:<id>config.eventSource→config.webhookSourceevent_source_wake→webhook_source_wakesourceKey→webhookKey/event-source-subscriptions/:id→/webhook-source-subscriptions/:id/_electric/event-sources→/_electric/webhook-sourcesKey Invariants
Non-goals
event_sourcealiases.event-source:<id>manifests.Trade-offs
This is a breaking rename rather than an additive compatibility layer. That keeps the runtime/server API smaller and avoids supporting duplicate names long-term, but requires downstream consumers to update in lockstep.
Verification
Completed:
GITHUB_BASE_REF=main node scripts/check-changeset.mjs # ✅ Changesets cover all affected packages: @electric-ax/agents-runtime, @electric-ax/agents-server, @electric-ax/agentsgit diff --check # passesAttempted targeted runtime tests:
pnpm --filter @electric-ax/agents-runtime test webhook-sources.test.ts webhook-source-tools.test.ts --runThis failed before collecting tests because the fresh worktree did not have all dependencies installed:
Suggested follow-up checks after dependencies are installed:
Also verify downstream Stratovolt/cloud updates against
docs/stratovolt-webhook-source-rename-followup.mdbefore consuming the renamed APIs.Files changed
.changeset/rename-webhook-sources.md— changeset for affected agents packages.packages/agents-runtime/src/webhook-sources.ts— renamed webhook-source subscription/wake helpers and types.packages/agents-runtime/src/tools/webhook-sources.ts— renamed agent tools and manifest parsing to webhook-source terminology.packages/agents-runtime/src/index.ts,types.ts, context/runtime/client files — exported and wired newWebhookSource*names.packages/agents-server/src/routing/*,src/index.ts,src/server.ts,src/entity-manager.ts— renamed tenant context, catalog APIs, and subscription routes.packages/agents/src/agents/horton.ts, bootstrap/tests — updated prompt text and tool detection.docs/stratovolt-webhook-source-rename-followup.md— documents required downstream Stratovolt changes.