Skip to content

fix: harden desktop send response parsing#4575

Open
KyleAMathews wants to merge 3 commits into
require-pg-sync-urlfrom
fix-desktop-send-eoi
Open

fix: harden desktop send response parsing#4575
KyleAMathews wants to merge 3 commits into
require-pg-sync-urlfrom
fix-desktop-send-eoi

Conversation

@KyleAMathews

Copy link
Copy Markdown
Contributor

Summary

  • preserve configured auth headers when local Electron requests fall back from desktop IPC transport to browser fetch
  • replace raw res.json() calls in desktop send/session mutation paths with optional/required JSON helpers
  • add a regression test for local Electron FormData fallback header injection

Testing

  • pnpm --filter @electric-ax/agents-server-ui test -- --run src/lib/auth-fetch.test.ts

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Desktop Builds

Build artifacts for commit 23fc215.

Platform Status Artifact
macOS Apple Silicon Passed DMG
macOS Intel Passed DMG
Windows x64 Passed Installer
Linux x64 Passed AppImage / deb

Workflow run

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.76471% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.37%. Comparing base (cd8c467) to head (23fc215).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gents-server-ui/src/lib/ElectricAgentsProvider.tsx 0.00% 26 Missing ⚠️
packages/agents-server-ui/src/lib/sendMessage.ts 0.00% 19 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           require-pg-sync-url    #4575      +/-   ##
=======================================================
+ Coverage                56.74%   58.37%   +1.62%     
=======================================================
  Files                      327      370      +43     
  Lines                    38000    40763    +2763     
  Branches                 10953    11576     +623     
=======================================================
+ Hits                     21564    23795    +2231     
- Misses                   16401    16894     +493     
- Partials                    35       74      +39     
Flag Coverage Δ
packages/agents 71.36% <ø> (ø)
packages/agents-mcp 77.70% <ø> (?)
packages/agents-mobile 75.49% <ø> (ø)
packages/agents-runtime 82.48% <ø> (-0.02%) ⬇️
packages/agents-server 75.05% <ø> (+0.02%) ⬆️
packages/agents-server-ui 6.29% <11.76%> (+0.04%) ⬆️
packages/electric-ax 46.42% <ø> (ø)
packages/experimental 87.73% <ø> (?)
packages/react-hooks 86.48% <ø> (?)
packages/start 82.83% <ø> (?)
packages/typescript-client 91.71% <ø> (?)
packages/y-electric 56.05% <ø> (?)
typescript 58.37% <11.76%> (+1.62%) ⬆️
unit-tests 58.37% <11.76%> (+1.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Electric Agents Mobile Build

Local mobile checks ran for commit 23fc215.

The EAS Android preview build was skipped because the mobile-eas-build label is not present.
Add the mobile-eas-build label to this PR to produce an installable preview build.

Workflow run

@KyleAMathews KyleAMathews force-pushed the fix-desktop-send-eoi branch from 9c98f14 to 768e154 Compare June 11, 2026 19:42
@KyleAMathews KyleAMathews changed the base branch from main to require-pg-sync-url June 11, 2026 19:42
@KyleAMathews KyleAMathews force-pushed the fix-desktop-send-eoi branch 4 times, most recently from afd8845 to b9d8886 Compare June 12, 2026 03:46
@KyleAMathews KyleAMathews force-pushed the fix-desktop-send-eoi branch from b9d8886 to 23fc215 Compare June 12, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant