fix: harden desktop send response parsing#4575
Open
KyleAMathews wants to merge 3 commits into
Open
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## require-pg-sync-url #4575 +/- ##
=======================================================
+ Coverage 56.74% 58.37% +1.62%
=======================================================
Files 327 370 +43
Lines 38000 40763 +2763
Branches 10953 11576 +623
=======================================================
+ Hits 21564 23795 +2231
- Misses 16401 16894 +493
- Partials 35 74 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Electric Agents Mobile BuildLocal mobile checks ran for commit The EAS Android preview build was skipped because the |
9c98f14 to
768e154
Compare
afd8845 to
b9d8886
Compare
b9d8886 to
23fc215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
res.json()calls in desktop send/session mutation paths with optional/required JSON helpersTesting