Require explicit pg-sync source URLs#4576
Open
KyleAMathews wants to merge 8 commits into
Open
Conversation
Contributor
Contributor
Electric Agents Mobile BuildLocal mobile checks ran for commit The EAS Android preview build was skipped because the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
==========================================
- Coverage 58.35% 56.74% -1.61%
==========================================
Files 370 327 -43
Lines 40674 38000 -2674
Branches 11553 10953 -600
==========================================
- Hits 23735 21564 -2171
+ Misses 16865 16401 -464
+ Partials 74 35 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Exclude per-request metadata (wakeId, principal, tenant) from the sourceRef hash so re-registrations reuse the same bridge and stream, and fetch the shape log once before registering so bad URLs fail the registration with Electric's error instead of dying silently in the bridge retry loop. Add Horton prompt guidance for the now-required shape URL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Electric returns 200 on non-shape paths like its root, so an ok status alone can't validate a source URL. The probe now requires the electric-handle header and suggests the /v1/shape path when missing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlfor theobserve_pg_syncHorton tool and the server pg-sync register routeTesting