fix: don't kill the primary instance on large second-instance messages - #53156
Open
VerteDinde wants to merge 1 commit into
Open
fix: don't kill the primary instance on large second-instance messages#53156VerteDinde wants to merge 1 commit into
VerteDinde wants to merge 1 commit into
Conversation
#52628) The POSIX process singleton read a second instance's notification into a fixed 32 KiB buffer and gave up as soon as writing to the socket would block. Command lines or additionalData payloads beyond those limits were either silently truncated or, when the write couldn't complete, made the second instance kill the primary process as unresponsive. (cherry picked from commit 1652d8e)
VerteDinde
added
backport
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52628
See that PR for details.
Manual backport notes: the only conflict was inside
patches/chromium/feat_add_data_parameter_to_processsingleton.patch— this branch's copy differs frommain's pre-#52628 copy by one context line (base/functional/callback.hvscallback_helpers.hinprocess_singleton.h), which together withmain-only blob hashes defeats the 3-way apply. Re-anchored the patch against this branch's Chromium; theprocess_singleton_posix.ccchange is byte-identical tomain.e sync --3applies the full series cleanly andlint --patchespasses. Not built locally for 43-x-y (no RBE auth on this machine); the identical change was built and exercised on the 42-x-y backport.Notes: Fixed the primary instance being killed or receiving truncated arguments when a second instance passed a very long command line or large
additionalDatatoapp.requestSingleInstanceLock().