Draft
Conversation
BREAKING CHANGE: Drops support for Node < 10.17.
Cannot unvendor because Squirrel.exe executes that specific rcedit.exe
malept
force-pushed
the
malept/feat/node-10
branch
from
8db7f6f to
8654f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop support for Node < 10.17
Allows running some of the module within WSL1/WSL2 by detecting those environments and executing the Windows EXEs directly.
Also updated all of the dependencies while in there.
Note: this does not fix the EXE calls within Squirrel itself, as it's written in compiled languages. That would require code changes in
Squirrel.Windows, and then the vendored executables would need to be updated.Related: electron/node-rcedit#71