Skip to content

Conversation

@vyagubov
Copy link
Contributor

@vyagubov vyagubov commented Dec 18, 2025

See: #1993

  • changed pyproject.toml : python 3.13 is available.
  • Built and tested elementary in python 3.13 environment.

Summary by CodeRabbit

  • Chores
    • Extended Python support to include Python 3.13.
    • Removed an outdated compatibility note to keep project metadata current.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

👋 @vyagubov
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

Python upper bound in pyproject.toml was relaxed from <3.13 to <3.14; an associated comment about dbt/numpy compatibility was removed. No other files or code changes were included.

Changes

Cohort / File(s) Summary
Project metadata
pyproject.toml
Updated Python compatibility constraint from >=3.9,<3.13 to >=3.9,<3.14; removed a comment line referencing dbt/numpy compatibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single configuration file with a simple version bound change and comment removal.

Poem

🐰
I hopped through lines of tidy text,
A small bound nudged to the next,
No code to chew, no tests to sweep,
Just one soft change before I sleep.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Python 3.13 support' directly and accurately reflects the main change: updating Python dependency constraints from <3.13 to <3.14 to enable Python 3.13 support, which aligns with the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3624b8b and aa9167a.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

16-16: Verify the networkx version constraint and test Python 3.13 compatibility for packages with relaxed upper bounds.

Most dependencies support Python 3.13, but the networkx constraint needs clarification: if set to <3, it would allow v2.x which is incompatible with Python 3.13. Additionally, verify that pydantic is constrained to v2.8+ (not lower v2 versions) and that actual testing confirms runtime compatibility across the entire dependency tree.

@vyagubov vyagubov deployed to elementary_test_env December 18, 2025 14:11 — with GitHub Actions Active
@vyagubov
Copy link
Contributor Author

@arbiv @NoyaOffer
I have tested the edr command in Python 3.13. Please review it when you have a chance. I am open to any feedback, fixes, tests, or refactorings.
A release at your earliest convenience would be greatly appreciated.

@arbiv
Copy link
Contributor

arbiv commented Dec 28, 2025

Thanks @vyagubov, will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants