Repository navigation
ListBox: add focus styles for default rows - #1085
Open
danirabbit wants to merge 6 commits into
Open
danirabbit wants to merge 6 commits into
danirabbit wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@ztefn please don't spam other pull requests |
ryonakano
reviewed
Oct 20, 2026
| min-height: rem(32px); //Try to force homogeneous row height | ||
| } | ||
|
|
||
| // Not a Granite.ListItem |
Member
There was a problem hiding this comment.
This might be just because I'm not familiar with the context, but would you tell me what you mean with this comment?
Member
Author
There was a problem hiding this comment.
Ah yeah. This could be clearer. Granite.ListItem styles its own focus. So this is a focus style for other list item child that aren't Granite.ListItem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add keyboard focus style for non-listitem rows like in ShortcutOverlay