Skip to content

Styles/Button: clean up suggested and destructive styles - #1086

Merged
danirabbit merged 4 commits into
mainfrom
danirabbit/styles/button-suggesteddestructive
Oct 20, 2026
Merged

danirabbit merged 4 commits into
mainfrom
danirabbit/styles/button-suggesteddestructive

Conversation

@danirabbit

Copy link
Copy Markdown
Member
  • Move suggested and destructive styles to their own little section. Just feels nicer to group these
  • Fixes issues with button backgrounds changing/dissappearing/etc in active states
  • Make sure borders always look nice in dark mode
  • Unify colors between text-button and image-button
  • Use some CSS magic to improve contrast

AFTER

Screenshot from 2026-10-15 15 57 43 AAA 8.6 Screenshot from 2026-10-15 15 57 24 AA 5.4 Screenshot from 2026-10-15 15 57 35 AA 5.3

BEFORE

Screenshot from 2026-10-15 15 58 08 AA 5.2 Screenshot from 2026-10-15 15 58 26 A 3.9 Screenshot from 2026-10-15 15 58 16 X 2.7

@danirabbit
danirabbit requested a review from a team October 15, 2026 23:02
@danirabbit danirabbit added this to OS 9 Oct 15, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Oct 15, 2026
@danirabbit
danirabbit merged commit 5f56358 into main Oct 20, 2026
3 of 5 checks passed
@ryonakano
ryonakano deleted the danirabbit/styles/button-suggesteddestructive branch October 21, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

2 participants