Emotes: update symbolic icons for gtk 4.22#1423
Conversation
|
@garaevdi Thank you for your work. Are there any following PRs to make symbolic icons compatible with GTK 4.22 or is this the last one? |
|
I'm not sure who in the elementary GitHub Organization I should ask (probably @elementary/ux?), but can we have a new release of Icons once all symbolic icons get compatible with GTK 4.22? I'd like to use it in the new release of flatpak-platform (elementary/flatpak-platform#215) which comes with GTK 4.22. |
Hi @ryonakano, there are 6 more PRs (one per icon type). I can rapid fire them, but some require a bit more work. |
|
I've tested this branch with GTK 4.22.4 (built and installed from git) using Icon Browser (built and installed from git1) on OS 8 Early Access, and confirmed all emotes symbolic icons are now rendered and won't be empty. BeforeNot all but almost of all emotes symbolic icons are empty, e.g. face-angel-symbolic: 
After
Proof of Environment
Footnotes
|
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Approval from non-UX team though.
|
Ah wait, I should have tested with older GTK on OS 8 Stable, hang on…… |
ryonakano
dismissed
their stale review
Missing test with older version of GTK for compatibility
|
Tested with GTK 4.14.5 that comes with latest OS 8 Stable too, and confirmed all icons still rendered as before.
Proof of Environment
|
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Re-approval from non-UX team member who confirmed all modified icons are rendered both with GTK 4.14 and 4.22.
2 participants
Part three of grand refactor to make symbolic icons work with gtk 4.22. Not sure what the future of emotes in icon themes are, but since they are still with us today, let's fix them up.