MainWindow: use Adw.ToolbarView - #556
Merged
Merged
Conversation
Member
|
I have an issue with this because on the process view the topbar has the bottom border visible, but on the System view it disappears. From my perspective it is better to have the same style on both views. Are we going to miss anything besides styles, if we will not switch to |
Member
Author
|
@stsdc I did that on purpose because otherwise you have separators going into nowhere:
And on the process view, the shadow shows when you scroll:
|
Member
|
Understood. NGL SystemView looks much cleaner, but it is inconsistent with the ProcessView. |
Member
Author
|
@stsdc done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


So we can easily switch styles per view