Skip to content

MainWindow: use Adw.ToolbarView - #556

Merged
stsdc merged 6 commits into
mainfrom
danirabbit/toolbox
Sep 16, 2026
Merged

stsdc merged 6 commits into
mainfrom
danirabbit/toolbox

Conversation

@danirabbit

@danirabbit danirabbit commented Sep 15, 2026

Copy link
Copy Markdown
Member

So we can easily switch styles per view

Screenshot from 2026-09-15 11 04 14 Screenshot from 2026-09-15 11 04 19

@danirabbit
danirabbit requested a review from a team September 15, 2026 18:04
@stsdc

stsdc commented Sep 15, 2026

Copy link
Copy Markdown
Member

I have an issue with this because on the process view the topbar has the bottom border visible, but on the System view it disappears. From my perspective it is better to have the same style on both views. Are we going to miss anything besides styles, if we will not switch to Adw.ToolbarView?

@danirabbit

Copy link
Copy Markdown
Member Author

@stsdc I did that on purpose because otherwise you have separators going into nowhere:

Screenshot from 2026-09-15 11 43 42

And on the process view, the shadow shows when you scroll:

Screenshot from 2026-09-15 11 43 22

@stsdc

stsdc commented Sep 15, 2026

Copy link
Copy Markdown
Member

Understood.
Can we have the separator on both views? Or add the bottom border 1px grey solid to the Headerbar?

NGL SystemView looks much cleaner, but it is inconsistent with the ProcessView.

@danirabbit

Copy link
Copy Markdown
Member Author

@stsdc done :)

@stsdc stsdc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danirabbit thank you!

@stsdc
stsdc merged commit 2ae0cf8 into main Sep 16, 2026
3 of 7 checks passed
@stsdc
stsdc deleted the danirabbit/toolbox branch September 16, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants