Add Logs View - #558
Merged
Merged
Add Logs View#558
Conversation
Add missing files
Merged
Member
|
Please don't forget to update POTFILES :) |
Member
Author
|
@ryonakano oops thanks for the reminder |
stsdc
requested changes
Sep 16, 2026
Co-authored-by: Stanisław <6031763+stsdc@users.noreply.github.com>
Co-authored-by: Stanisław <6031763+stsdc@users.noreply.github.com>
stsdc
approved these changes
Sep 16, 2026
stsdc
left a comment
stsdc
left a comment
Member
There was a problem hiding this comment.
I think we must have a separate searchbox for the Logs. Currently the same keyword works both for the process list and logs list:
I'm not sure how the stack transition will apply to it if it's going to be in the same place. But we need a separate placeholder text and possibility to preserve last searched text. This could be done in another PR since we have a lot of changes already. So I give it a conditional go.
Member
Author
|
Ah I actually really liked that it keeps the same search. I thought of it as a feature. Maybe try it a little before deciding you don't like it? We can always update placeholder text per view too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439