Conversation
In ProcessDRM.vala: - Don't aggressively reset gpu_percentage back to zero. - In calculate_percentage_ns () guard against negative results. In ProcessTreeView.vala and model/data: - Preserve cpu/gpu percentages as double - avoid cast to int. - Display cpu/gpu percentages with two decimal places (format "%0.2f") so as to not confuse people thinking all percentages look like zero. In test_process_drm.vala: - Unsure if exact comparison double == -1.0 will work, so check double < 0 instead? Thank you for your attention to this matter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ProcessDRM.vala:gpu_percentageback to zero.calculate_percentage_ns ()guard against negative results.In
ProcessTreeView.valaand model/data:"%.2f") so as to not confuse people thinking all percentages look like zero.In
test_process_drm.vala:double == -1.0will work, so checkdouble < 0instead?