fix: reject blanks for required path params - #141
Open
sapihav wants to merge 1 commit into
Open
Conversation
Reject empty strings, whitespace-only strings and null before URL construction. Preserve ordered errors, global fallback and optional parameter behavior. Cover validation and overrides with 27 test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fair disclaimer: fix vibed with Astra, but reviewed and verified manually
Problem
ElevenLabs CLI v1.1.0 accepts an empty value for the required
voice_idpath parameter. It then sends the request to/v1/text-to-speech/, which returns a misleadingNot Foundinstead of a local validation error.Observed on macOS, Apple Silicon.
Reproduction
No credentials or API request are needed:
Before this change, the dry run succeeds and includes:
{ "method": "POST", "url": "https://api.elevenlabs.io/v1/text-to-speech/" }Without --dry-run, the API returns:
A dry run does not contact the API or create an audio file; the bug is that it accepts the invalid path value.
After this change, the same command exits with code
3and reports:Fix and verification
Add
is_blank_path_valueinto validation loopsBefore
After