Conversation
There was a problem hiding this comment.
Pull request overview
Adds an mDNS advertisement for device and firmware metadata so Nerves devices can be discovered and identified on the local network.
Changes:
- Calls a new
advertise_device/0helper during application startup (non-host only). - Registers an
MdnsLitemDNS service with TXT records containing serial and firmware metadata.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
11
| advertise_device() | ||
| setup_wifi() |
There was a problem hiding this comment.
The project already configures mDNS services via config :mdns_lite, services: [...] (see config/target.exs:40-73). Adding another service imperatively in Application.start/2 splits configuration across places and makes it harder to audit/override. Prefer moving this service definition into the existing :mdns_lite config (and keep start/2 focused on supervision/runtime wiring).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.