Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
show_titleand an optional, boundedmargin_topon dialogs. Callers can build search-first dialogs without a visible heading and choose a fixed top offset. Omitting the new options preserves visible titles and the native viewport-relative placement.Keep the existing controlled-open behavior, content activation, focus handling, and Escape closure. Regenerate both native component schemas from the shared declaration, including optional numeric decoding.
Evidence
A native regression switches a dialog from titled to headerless and verifies that the heading row disappears while content activation and Escape still work. The native navigation suite passes all eight cases. Builder coverage checks defaults, explicit offsets, and rejection of invalid offsets. Visually inspected a real native fixture at an 80px top margin.
Clean package validation remains blocked in the unchanged transitive
gpui-componentdependency by incompatible upstream APIs, before compiling this bridge.Release Notes: