Skip to content

Simplify insert/2 common case #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhunleth merged 1 commit into from
May 10, 2026
+2 −2
Merged

Simplify insert/2 common case #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/circular_buffer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ defmodule CircularBuffer do
Inserts a new item into the next location of the circular buffer
"""
@spec insert(t(), any()) :: t()
def insert(%CB{b: b} = cb, item) when b != [] do
%{cb | a: [item | cb.a], b: tl(b)}
def insert(%CB{a: a, b: [_ | tl_b]} = cb, item) do
%{cb | a: [item | a], b: tl_b}
end

def insert(%CB{count: count, max_size: max_size} = cb, item) when count < max_size do
Expand Down