Repository navigation
fix(build): apply netvsc leak fix and centralize dependency patches - #22
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPDK's netvsc event-buffer expansion leaks the old allocation when
rte_realloc()fails. Vendor the fix underthird_party/patches/dpdk/and apply it before Bycorf configures and compiles DPDK, so source builds include the fix automatically.Group dependency patches under
third_party/patches/<dependency>/, moving the existing FreeBSD TCP patch unchanged intothird_party/patches/freebsd/. Update the FreeBSD build helper and CMake dependency tracking to use its new location; it still patches a fresh build-directory copy and preserves imported source digests. Both directories use the shared patch-byte preservation attributes.The patch helper checks the complete reverse patch to recognize an already-patched checkout. Otherwise it validates the forward patch before applying it, rejecting conflicts and partial applications. Patch changes trigger CMake reconfiguration. Preserve the supplied patch bytes and document that patching changes the DPDK submodule working tree; external
BYCORF_DPDK_PREFIXinstallations must include the patch themselves.Validation:
bus/vmbus,net/netvscenabled through the productioncmake/Dpdk.cmakemodule in an isolated CMake harness, including compilation of the patchedhn_rxtx.c.cmake --buildrerun configuration and recognize the already-applied patch.git diff --cached --checkpassed.Validation covers build integration and patch handling; no netvsc hardware allocation-failure test was run.