Repository navigation
feat(storage): use IX for bounded zset pops and range removals - #438
Open
thweetkomputer wants to merge 1 commit into
Open
thweetkomputer wants to merge 1 commit into
thweetkomputer wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
thweetkomputer
force-pushed
the
zset-selection-intent-writes
branch
from
November 5, 2026 11:12
ad73306 to
ca6bee8
Compare
thweetkomputer
force-pushed
the
zset-batch-intent-writes
branch
from
November 5, 2026 11:12
5a48feb to
3a5ca5a
Compare
thweetkomputer
force-pushed
the
zset-selection-intent-writes
branch
from
November 5, 2026 12:35
ca6bee8 to
1edbdc6
Compare
thweetkomputer
force-pushed
the
zset-batch-intent-writes
branch
from
November 5, 2026 12:35
3a5ca5a to
155ba11
Compare
thweetkomputer
force-pushed
the
zset-selection-intent-writes
branch
from
November 6, 2026 05:07
1edbdc6 to
786d2ad
Compare
thweetkomputer
force-pushed
the
zset-batch-intent-writes
branch
from
November 6, 2026 05:07
155ba11 to
1b60c26
Compare
thweetkomputer
force-pushed
the
zset-selection-intent-writes
branch
from
November 6, 2026 06:13
786d2ad to
d6dd9d7
Compare
thweetkomputer
force-pushed
the
zset-batch-intent-writes
branch
from
November 6, 2026 06:13
1b60c26 to
c0f10be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone ZPOPMIN/ZPOPMAX and ZREMRANGE variants now use IX for topology-preserving deletions. Select with temporary S groups, release them, then acquire member X and merged ordered X/S requirements in identity order. Validate the selection's relevant page revisions and retain predicate protection through publication; changed selections fall back once to key X. Unrelated root publications can continue without forcing a retry.
Score ranges and endpoint pops protect their interval and neighbours. Rank and mixed-score lexical removals protect the whole ordered graph because changes elsewhere affect the predicate, while unrelated member reads can continue. Guaranteed page-emptying removals go directly to the structural X path. Multi-key aggregation/STORE, blocking or multi-key pops, compact values and externally locked transactions keep their existing paths.
Validation: Debug and Release builds; 67 focused unit tests and 81 grouped E2E tests pass, including crash recovery, OOM, EXEC and existing command surfaces. New deterministic tests cover selective progress, predicate conflicts, selection invalidation by score changes/deletion, and unrelated publications between selection and mutation.
Stacked on #437; this PR contains only selected deletions and endpoint pops.