feat: active pane indicator in split view#29
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds an active-state style and toggle behavior to PostSplitModal (POST vs README/COMMENTS), updates tests to assert the active-class behavior, removes ContentModal and CommentsModal modules and their public re-exports, and updates Reddit source config (user-agent, hot-with-after URL) and httpx client instantiation. ChangesPostSplitModal active-state and tests
Widget removals and package exports
Reddit source config and client behavior
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 79.30% 82.41% +3.10%
==========================================
Files 18 16 -2
Lines 1068 978 -90
==========================================
- Hits 847 806 -41
+ Misses 221 172 -49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_widgets.py`:
- Around line 169-170: The test only asserts the POST label is active; also
query the COMMENTS label (e.g., app.query_one("#pane-label-comments", Label) or
the actual comments label id used elsewhere) and assert that
"pane-label--active" is not in its .classes to ensure COMMENTS is inactive—add
this symmetric assertion right after the existing post_label check to prevent
false positives where both labels could be active.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ab45f26d-7139-45f1-8af0-9509a5f3150f
📒 Files selected for processing (2)
devskim/widgets/post_split_modal.pytests/test_widgets.py
…across all themes
PostSplitModal replaced both modals. Remove the dead files, their exports, and corresponding tests. Fix Reddit 403 by passing http2=False to httpx.AsyncClient; Reddit blocks HTTP/2 connections.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_widgets.py`:
- Around line 92-161: The file tests/test_widgets.py is failing ruff formatting;
run the formatter (e.g., ruff format tests/test_widgets.py or ruff format .) to
fix whitespace/import/format issues in the test functions
(test_post_split_modal_initial_active_class,
test_post_split_modal_switch_pane_toggles_class,
test_post_split_modal_switch_pane_twice_restores) and any patched symbol usage
(PostSplitModal._load_comments), then stage and commit the formatted file so CI
passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 11b50cac-2e02-414c-b6f2-7b56f97ac829
📒 Files selected for processing (5)
devskim/sources/reddit.pydevskim/widgets/__init__.pydevskim/widgets/comments_modal.pydevskim/widgets/content_modal.pytests/test_widgets.py
💤 Files with no reviewable changes (2)
- devskim/widgets/content_modal.py
- devskim/widgets/comments_modal.py
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
query_one in on_mount was unreliable in CI before children finish mounting. Setting classes= in Vertical() constructor is race-free. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
.pane-label--activeCSS class: active pane label renders in$accentcolor + bold$text-muted(dimmed)▶arrow retained for non-color terminalsTabkeypress viaaction_switch_paneon_mountTest plan
Enter→ POST label highlighted in accent colorTab→ COMMENTS/README label highlights, POST dimsTabagain → POST highlights, COMMENTS dimsSummary by CodeRabbit
Style
Tests
Chores
Breaking Changes