support empty rootURL with Ember CLI >= 5.0#196
Open
jelhan wants to merge 2 commits intoember-cli:masterfrom
Open
support empty rootURL with Ember CLI >= 5.0#196jelhan wants to merge 2 commits intoember-cli:masterfrom
jelhan wants to merge 2 commits intoember-cli:masterfrom
Conversation
jelhan
commented
Oct 17, 2023
Comment on lines
+51
to
+56
| let baseURL = options.liveReloadBaseUrl ?? options.rootURL ?? options.baseURL; | ||
|
|
||
| // express requires absolute paths | ||
| if (baseURL === '') { | ||
| baseURL = '/'; | ||
| } |
Author
There was a problem hiding this comment.
As an alternative pattern we could fall back to '/' not only if baseURL is an empty string but always when it is falsy. This would match previous behavior of Ember CLI more closely as options.baseURL had such a fallback.
Suggested change
| let baseURL = options.liveReloadBaseUrl ?? options.rootURL ?? options.baseURL; | |
| // express requires absolute paths | |
| if (baseURL === '') { | |
| baseURL = '/'; | |
| } | |
| let baseURL = options.liveReloadBaseUrl || options.rootURL || options.baseURL || '/'; |
I'm not much opinionated on either or option.
This was referenced Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until Ember CLI v5 the
baseURLwas set to'/'ifrootURLwas an empty string. Since Ember CLI v5 thebaseURLis not set anymore on theconfig.optionsobject at all. This change causes ember-cli-live-reload to break if applications setbaseURL = ''in theconfig/environment.js.Nullish coalescing operator should solve the issue as it does not fall back to
baseURLifrootURLis an empty string.Please find a simple reproduction here: https://github.com/jelhan/ember-app-with-relative-root-url
ember serveis working fine for the last commit using Ember CLI v4.12. If you go back one commit, which uses Ember CLI v5.0 it breaks with the error mentioned above.