Added liveReloadJsUrl config#37
Open
williamweckl wants to merge 1 commit intoember-cli:masterfrom
Open
Conversation
|
@williamweckl This fix resolves my problem. Test on my project and it worked correctly. |
| app.use(baseURL + 'ember-cli-live-reload.js', function(request, response, next) { | ||
| response.contentType('text/javascript'); | ||
| response.send(self.dynamicScript(options)); | ||
| response.send(self.dynamicScript()); |
There was a problem hiding this comment.
This point memory leakage.
https://auth0.com/blog/four-types-of-leaks-in-your-javascript-code-and-how-to-get-rid-of-them/
| if (liveReloadOptions.snipver === undefined) { | ||
| liveReloadOptions.snipver = 1; | ||
| } | ||
| dynamicScript: function(request) { |
There was a problem hiding this comment.
This variable request is never used!
| @@ -5,23 +5,18 @@ module.exports = { | |||
|
|
|||
| contentFor: function(type) { | |||
| var liveReloadPort = process.env.EMBER_CLI_INJECT_LIVE_RELOAD_PORT; | |||
There was a problem hiding this comment.
This variable liveReloadPort is never used!
| var liveReloadPort = process.env.EMBER_CLI_INJECT_LIVE_RELOAD_PORT; | ||
| var baseURL = process.env.EMBER_CLI_INJECT_LIVE_RELOAD_BASEURL; | ||
|
|
||
| if (liveReloadPort && type === 'head') { |
There was a problem hiding this comment.
change liveReloadPort by liveReloadJsUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the docs, the configuration to change javascript url is liveReloadJsUrl. Unfortunately, no code is using this config.
This PR fixes that.