partially address ember barrel depprecation via some light dependency updating #316
Merged
evoactivity merged 5 commits intomasterfrom Apr 17, 2026
Merged
partially address ember barrel depprecation via some light dependency updating #316evoactivity merged 5 commits intomasterfrom
evoactivity merged 5 commits intomasterfrom
Conversation
void-mAlex
reviewed
Apr 17, 2026
| import config from 'docs/config/environment'; | ||
| import { setApplication } from '@ember/test-helpers'; | ||
| import { start } from 'ember-qunit'; | ||
| import { loadTests } from 'ember-qunit/test-loader'; |
There was a problem hiding this comment.
this should all be done via e-c-u
this is just part of the upgrade and is very selective
Contributor
Author
There was a problem hiding this comment.
everyone says ECU PRs are too big to review.
and ECU doesn't do anything in a targeted way -- it's a sledge hammer.
It also tends to choose out of date things.
It's not the best tool for how I like doing upgrades.
evoactivity
reviewed
Apr 17, 2026
Contributor
evoactivity
left a comment
evoactivity
left a comment
There was a problem hiding this comment.
PR title doesn't match the changes made.
NullVoxPopuli
changed the title
Open
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't fix all of this in this PR, beecause I have to remove fastboot.
I can't remove fastboot without a docs solution (vite ember-ssr), and I can't use vite-ember-ssr until the pproject is on vite.
So after this PR, I'll update both apps to vite, and add SSR/SSG where approp