Closed
Conversation
The updated packages changed some of the rules which means our existing code needs changes.
This package is no longer maintained and uses deprecated API's that block the Ember v5 update. It does mean the frontend has to load an extra json file on some pages that previously loaded it from the FastBoot shoebox on initital renders.
This solves a dep issue with `@ember/test-helpers`
ember-data was throwing an error because it tries to (conditionally) import ember-inflector, which fails because we don't have it installed. To work around this we mark the deprecation solved so we don't hit the conditional code path at all. This does require an update to EmberData as well since the `@warp-drive/build-utils` package is not compatible with v5.3.
`structuredClone` is used by WarpDrive, so we need to add it to the FastBoot sandbox.
- remove unneeded transforms since the source data already provides the correct types - explicitly register the date transform we still use - explicitly register the store service
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to update to v5.12
Needs more work, some of the a11y tests are failing (I'm guessing because I bumped majors), not sure what's wrong there yet.
Builds on #1193 and #1194