vite w/ type=module#1200
Draft
NullVoxPopuli-ai-agent wants to merge 11 commits intoember-learn:mainfrom
Draft
Conversation
- Run ember-vite-codemod as starting point - Remove ember-cli-build.js and @embroider/compat - Add "type": "module" to package.json - Use ember-strict-application-resolver with import.meta.glob for module registration - Use @embroider/router for routing - Replace broccoli-based content-data-generator with scripts/generate-content.mjs - Custom vite plugin to resolve @ember/* and @glimmer/* virtual modules from ember-source - Upgrade to vite 8, @glimmer/component 2, ember-data 5.8, @ember/string 4 Removed v1 addons (need separate v2 conversion PRs): - ember-styleguide (UI components - needs v2 conversion) - ember-leaflet (replace with ember-maplibre-gl) - ember-responsive-image (replace with @responsive-image/ember) - ember-tether (replace with ember-primitives positioning) - ember-cli-fastboot / prember / ember-data-fastboot (SSR) - ember-cli-head, ember-body-class, ember-metrics - ember-href-to, ember-cached-decorator-polyfill - ember-cli-babel-polyfills, ember-cli-netlify Added: - ember-primitives - ember-strict-application-resolver - @embroider/router Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
this file is probably the most important part to focus on while I iterate on the what the bot thinks is correct 🙈
ember-a11y-testing@8 is a v2 addon and works without @embroider/compat. Restores all a11yAudit calls in test files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Provided by ember-source via the ember() vite plugin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add configFile: false to eslint babel parser to prevent auto-discovery of babel.config.mjs (which has async plugins) - Rename config/environment.js to .cjs for type=module compat - Fix blueprint glob patterns in eslint config - Remove @percy/ember imports from tests (v1 addon, removed) - Remove unused parseNestedValue function - Add hbs() plugin for .hbs template compilation - Add emberSourceResolver plugin to resolve @ember/* and @glimmer/* virtual modules to ember-source/dist/packages/ - Configure WarpDrive global config for @embroider/macros compilation - Two babel passes: full pass (excluding @warp-drive) + macros-only for @warp-drive - All @embroider/macros calls now compiled away (0 runtime fallbacks) Test results: 205 tests, 67 pass, 138 fail (failures expected - removed ember-styleguide components, percy, etc.) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… vite config - Replace manual WarpDrive macros config with setConfig() from @warp-drive/build-config - Remove custom compileMacrosInEmberSource plugin and second babel pass - Copy .netlifyheaders/.netlifyredirects to public/ as _headers/_redirects (previously handled by removed ember-cli-netlify addon) - Simplify vite.config.mjs — single babel pass handles all macros - All @embroider/macros calls properly compiled away (0 runtime references) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add exclude pattern to babel plugin to prevent recompiling pre-built v2 addon dist files (only ember-source is included for macros) - Use @warp-drive/build-config setConfig() for proper WarpDrive macros - Copy Netlify _headers/_redirects to public/ directory - ember-styleguide v2 blocked: its dist uses @ember/template-compiler which requires ember-source 6.x (not available on 5.12) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add ember-styleguide from git ref (NullVoxPopuli-ai-agent/ember-styleguide#convert-to-v2-addon) - Register ember-styleguide services (navbar, progress) in app.js - Restore EsHeader/EsFooter in application.hbs - Add @ember/test-waiters and ember-concurrency as dependencies - Fix babel filter to use function-based ID matching for pnpm deep paths (regex-based exclude doesn't work with pnpm's nested node_modules) - Process @ember/test-waiters through babel for macros compilation - All @embroider/macros compiled away in both production AND development builds Tests: 68/205 pass (remaining failures from removed v1 addons like ember-leaflet, ember-responsive-image, and percy) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Netlify needs explicit configuration to use pnpm (via corepack) and to publish the dist/ directory from the vite build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-vite-codemod"type": "module"to package.jsonember-strict-application-resolverwithimport.meta.glob()for module registration@embroider/routerfor routingember-cli-build.jsand@embroider/compatcontent-data-generatorwithscripts/generate-content.mjs@ember/*and@glimmer/*virtual modules from ember-source@glimmer/componentto v2,ember-datato 5.8,@ember/stringto v4Removed v1 addons (need separate v2 conversion PRs)
ember-styleguideember-leafletember-maplibre-glember-responsive-image@responsive-image/emberember-tetherember-primitives(floating-ui)ember-cli-fastboot/premberember-cli-headember-body-classember-primitivesbody classember-metricsember-href-toember-cached-decorator-polyfillember-cli-babel-polyfillsember-a11y-testingAdded dependencies
ember-primitives- modern UI primitivesember-strict-application-resolver- explicit module registration@embroider/router- vite-compatible routertestem- direct test runner (no ember-cli)Follow-up work
ember-styleguideto v2 addon (viaember-cli/ember-addon-blueprint)ember-leaflettoember-maplibre-glember-responsive-imageto@responsive-image/emberember-tetherusage withember-primitivespositioningember-metricswith direct GA or alternative)Test plan
vite buildsucceeds (371 modules transformed)vitedev server starts and pages rendervite build --mode development && testem ci🤖 Generated with Claude Code