Skip to content

Assigning class field without semicolon breaks template highlighting #18

Closed

Description

@andsmedeiros

Hello! Thanks for the useful extension!

There seems to be an issue with gjs files in a specific scenario:
When assigning a class field without using a semicolon and adding a <template> tag makes the whole template not be detected:

Image

(we are assigning setup without a semicolon, the whole template does not get recognised)

Image

(same thing but with the semicolon, template get highlighted)

This goes to some disturbing extent on multi-component files:

Image Image

(in this file with two components, beyond the two templates' contents, the white-washed section also swallows all of the JS content from the second component)

Activity

  1. NullVoxPopuli commented on May 1, 2026

    @NullVoxPopuli
    Member

    does the runtime work without semicolons? I thought they were required 🤔
    if they happen to not be required, want to take a stab at adding a lack of semi-colon support?

  2. NullVoxPopuli commented on May 1, 2026

    @NullVoxPopuli
    Member

    at the very least it seems some error recovery is needed

  3. andsmedeiros commented on May 7, 2026

    @andsmedeiros
    ContributorAuthor

    Key @NullVoxPopuli, I got a PR for this. I got claude to work the issue with guidance, tests are OK.

  4. andsmedeiros commented on May 21, 2026

    @andsmedeiros
    ContributorAuthor

    Fixed by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions